Review double border fix

NHSLeadership / nightingale

NHS-Generic Frontend Framework.

Other

35 stars 8 forks source link

Review double border fix #229

Open Android63 opened 6 years ago

Android63 commented 6 years ago

@csswizardry I've fixed issue https://github.com/NHSLeadership/nightingale/issues/224 but could you review please?

So you can easily find it, I've marked my fix (in _components.page-header.scss) with the comment "Temporary fix. See Nightingale issue #229".

I believe the issue occurred after you updated tools/_tools.mixins.scss to use table rather than block when there's both a before and after pseudo element. See 4d4f48a

penpadstudio commented 6 years ago

@Android63 as far as I can see this has not been resolved: screen shot 2018-07-10 at 11 32 04

csswizardry commented 6 years ago

@Pro-Paul: It appears to be fixed in develop:

@Android63: Good spot! That seems to be the fix 👍