search

NHSLeadership / nightingale

NHS-Generic Frontend Framework.
Other
35 stars 8 forks source link

Beta ribbon #251

Closed penpadstudio closed 6 years ago

penpadstudio commented 6 years ago

Summary:

The open in new window/tab icon is incorrect on the beta ribbon.

Steps to reproduce:

Open any page on the staging site. https://nhslwpcorporate.nightingale.qa.kops.nhsx.uk/

Expected results:

The open in new window/tab icon should be NHS black.

screen shot 2018-07-11 at 15 22 17

Actual results:

The open in new window/tab icon is currently NHS White. screen shot 2018-07-11 at 15 21 08

penpadstudio commented 6 years ago

Nightingale wiki for reference: https://github.com/NHSLeadership/nightingale/wiki/%28c%29Prototype-Ribbons

csswizardry commented 6 years ago

This is correct in Nightingale itself (i.e. this repo) so if there’s a bug elsewhere it probably needs filing elsewhere. This is what current develop looks like:

image

cehwitham commented 6 years ago

@Android63 @ishanivardhan are you able to implement this with the black icon in Moodle and WP?

csswizardry commented 6 years ago

FYI, the bug is in the implementation, not Nightingale. We just need to remove the u-links-darkbg class 👍

image