search

NIAEFEUP / Website-NIAEFEUP

NIAEFEUP Website
https://ni.fe.up.pt
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Added docker + docker-compose configuration #191

Closed imnotteixeira closed 4 years ago

imnotteixeira commented 4 years ago

Finally we can deploy our website with niployments!

The dockerfile starts the app with pm2 which will balance the load through various works, depending on the available cores :)

SocksDevil commented 4 years ago

image It also requires the minified versions of jquery and bootstrap, though they do not live in the repository. Is this supposed to happen?

imnotteixeira commented 4 years ago

image It also requires the minified versions of jquery and bootstrap, though they do not live in the repository. Is this supposed to happen?

Cannot test this right now, but can you add public/ prefix to the path of the scripts at src/templates/layouts/partials/footer.pug. It might be some misconfiguration on that part, due to moving everything under src/

SocksDevil commented 4 years ago

image It also requires the minified versions of jquery and bootstrap, though they do not live in the repository. Is this supposed to happen?

Cannot test this right now, but can you add public/ prefix to the path of the scripts at src/templates/layouts/partials/footer.pug. It might be some misconfiguration on that part, due to moving everything under src/

Yes I realize that, but if you check inside the repository, the minified version of the js files do not live inside the repository

miguelpduarte commented 4 years ago

Aren't they created by some build command? It would make sense for them to be dependencies (I've seen other packages do that, have the build dependencies injected into public and then served)

miguelpduarte commented 4 years ago

Also, I have previously ran this without downloading those specifically so I don't think they need to be in the repo, they must be handled by some dependencies for sure

SocksDevil commented 4 years ago

Also, I have previously ran this without downloading those specifically so I don't think they need to be in the repo, they must be handled by some dependencies for sure

I would assume so as well, but since running docker-compose up did not create these dependencies, then there should be something missing right?

imnotteixeira commented 4 years ago

@miguelpduarte @GuilhermeJSilva @xRuiAlves Can some of you pick this?, I have a lot on my plate atm, and this should be a simple wrap up ( just add the missing files, if needed - they were deleted somehow)