search

NIAEFEUP / nijobs-fe

[FRONTEND] A platform for companies to advertise their job opportunities to students
GNU General Public License v3.0
23 stars 3 forks source link

Changed the logout button order #193

Closed dfneves19 closed 2 years ago

dfneves19 commented 2 years ago

Changed the logout button order so it appears last. closes #153

TiagooGomess commented 2 years ago

You should rebase with develop before merging. DM me if you need help with that.

DoStini commented 2 years ago

The divider is not yet fixed isn't it? @dfneves19

image

dfneves19 commented 2 years ago

while logged in as a company the dividers are exactly the same, but when logged in as admin the logout divider is still a little deviated to the left.

CarlosMealha commented 2 years ago

So I fixed the divider problem with a trivial solution, adding a statement just to know if it's an admin or a company account authenticated, and then I duplicated the style, just changing the width percentage. What do you guys think?

image image

Naapperas commented 2 years ago

@DoStini please review this PR (since you requested changes previously, also because I would appreciate a second opinion)

CarlosMealha commented 2 years ago

@DoStini please review this PR (since you requested changes previously, also because I would appreciate a second opinion)

I think this would fix the problem image

BrunoRosendo commented 2 years ago

@CarlosMealha This was already approved but it needs to be rebased. Shouldn't take too long

CarlosMealha commented 2 years ago

@CarlosMealha This was already approved but it needs to be rebased. Shouldn't take too long

Okay, it's already done, please aprove it.