NIAEFEUP / nijobs-fe

[FRONTEND] A platform for companies to advertise their job opportunities to students
GNU General Public License v3.0
23 stars 3 forks source link

Feature/recover password #260

Closed DoStini closed 1 year ago

Naapperas commented 2 years ago

Can you post some prints of the feature ?

DoStini commented 2 years ago

There you go

https://user-images.githubusercontent.com/23351316/185762573-d9545688-5880-40dd-b240-c38cb41d1526.mov

BrunoRosendo commented 2 years ago

There you go Screen.Recording.2022-08-20.at.21.01.44.mov

From watching the video, the FE flow doesn't seem to match the BE implementation. I think this would make sense if the users received a simple short code. I don't think it makes sense for them to past this huge token into the field. I prefer the flow where they just click on the link, or instead simplify the token somehow (I'm not sure if that could have security concerns)

DoStini commented 2 years ago

The BE needs to be updated to follow this methodology. Shortning the code doesn't seem possible.

Naapperas commented 2 years ago

I'm with Bruno, pasting the link could be cumbersome, if we somehow could just click the link and proceed with the rest of the flow we should do that.

Also, the transition from "new password" to "login" seems weird but that might be just me

DoStini commented 2 years ago

I'm with Bruno, pasting the link could be cumbersome, if we somehow could just click the link and proceed with the rest of the flow we should do that.

I'll try a different approach, when clicking on the link, redirect with modal opened on the finish part.

Also, the transition from "new password" to "login" seems weird but that might be just me

How so? I think it makes sense to redirect to the login "page"

DoStini commented 2 years ago

https://user-images.githubusercontent.com/23351316/187799892-4a240ed5-b663-406c-b657-bdfde7de0360.mov

Naapperas commented 1 year ago

@DoStini is this ready for review ?