Open FranciscoCardoso913 opened 1 year ago
The workflow regarding this issue has been changed You can check it here: https://github.com/NIAEFEUP/nijobs-be/pull/306#issuecomment-1447121249
@FranciscoCardoso913 @dsantosferreira any progress on this?
We have our first version of the warnings shown to users whose accounts aren't yet verified in the "Create an offer" and "My offers" pages. Feel free to share your opinions!
We have our first version of the warnings shown to users whose accounts aren't yet verified in the "Create an offer" and "My offers" pages. Feel free to share your opinions!
I like how it turned out! I just have some doubts about the icon. Is it also from material UI? The style seems a bit off from the rest of your icons, is it imported from @material-ui/icons
or somewhere else?
Assuming it is the right one, I guess it's the one on the right. Do you mind trying out the first one and see how it looks like?
The icon on the images I sent is the default one used by the alert component from material UI when the severity attribute is set to "warning". It is probably the "WarningAmber" icon, as you referred. Here is the alert with the filled version of the icon. I prefer the outlined one but tell me what you think!
The icon on the images I sent is the default one used by the alert component from material UI when the severity attribute is set to "warning". It is probably the "WarningAmber" icon, as you referred. Here is the alert with the filled version of the icon. I prefer the outlined one but tell me what you think!
Honestly, I prefer the filed version of the icon.
The icon on the images I sent is the default one used by the alert component from material UI when the severity attribute is set to "warning". It is probably the "WarningAmber" icon, as you referred. Here is the alert with the filled version of the icon. I prefer the outlined one but tell me what you think!
I do think the filled version looks more like the remaining icons we use (from what I recall, but feel free to check it out)
Patch coverage: 94.84%
and project coverage change: +0.52%
:tada:
Comparison is base (
0cab005
) 89.19% compared to head (23032fa
) 89.71%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Important:
This is a backend issue! See the original issue and the changes made in the backend here: https://github.com/NIAEFEUP/nijobs-be/pull/306
Discussed solution:
Front-End changes:
States of the new page:
What is yet to be done:
Doubts: