NIAEFEUP / nijobs-fe

[FRONTEND] A platform for companies to advertise their job opportunities to students
GNU General Public License v3.0
23 stars 3 forks source link

Validate company application page #309

Open FranciscoCardoso913 opened 1 year ago

FranciscoCardoso913 commented 1 year ago

Important:

This is a backend issue! See the original issue and the changes made in the backend here: https://github.com/NIAEFEUP/nijobs-be/pull/306

Discussed solution:

-When created, applications should have a state UNVERIFIED by default instead of the current PENDING state;

-After creating an application an email with a link should be sent to the company so they can validate their application, the link should expire in 10 minutes;

-A company should not be able to create an application with an email associated with an UNVERIFIED application whose link is yet to expire;

-If the link of an application expires and the company tries to create another application the previous application of that company should be deleted;

-The link should send the user to a page where the application is validated, when validating the application its state should change to pending and an email should be sent to the company.

Front-End changes:

-You can now search for unverified applications;

Screenshot from 2023-02-11 20-18-26

-The message which appeared after creating an application has now changed to indicate the company they have to validate their application;

Screenshot from 2023-02-11 20-14-37

-New error message when trying to create a new application with an email associated with an UNVERIFIED application whose link is yet to expire;

Screenshot from 2023-02-11 20-34-35

-Created a new page for validating the company, the page displays various messages indicating if the validation was successful or if an error has occurred;

States of the new page:

-Page when loading:

Screenshot from 2023-02-11 20-22-53

-Page when everything goes well:

Screenshot from 2023-02-11 20-25-06

 -Page when the application was already validated:

Screenshot from 2023-02-11 20-30-44

-Page when the application does not exist(the token in the link is incorret):

Screenshot from 2023-02-11 20-27-41

-Page when the link has expired:

Screenshot from 2023-02-11 20-26-34

-Page when an unexpected error occurs:

Screenshot from 2023-02-11 20-28-51

What is yet to be done:

 -Tests;

 -Google analytics;

Doubts:

-The error messages used have a style made by us, however, there already exists a template style to display errors ( a component called ErrorComponent), should we use that or keep it as it is?

-Should we change any of the designs of the validation page?

-Should we change any of the texts? 

-Is everything in the correct place or is there anything that is more adequate somewhere else?
FranciscoCardoso913 commented 1 year ago

Important

The workflow regarding this issue has been changed You can check it here: https://github.com/NIAEFEUP/nijobs-be/pull/306#issuecomment-1447121249

Naapperas commented 1 year ago

@FranciscoCardoso913 @dsantosferreira any progress on this?

dsantosferreira commented 1 year ago

We have our first version of the warnings shown to users whose accounts aren't yet verified in the "Create an offer" and "My offers" pages. Feel free to share your opinions!

warning1 warning2

BrunoRosendo commented 1 year ago

We have our first version of the warnings shown to users whose accounts aren't yet verified in the "Create an offer" and "My offers" pages. Feel free to share your opinions!

warning1 warning2

I like how it turned out! I just have some doubts about the icon. Is it also from material UI? The style seems a bit off from the rest of your icons, is it imported from @material-ui/icons or somewhere else?

Assuming it is the right one, I guess it's the one on the right. Do you mind trying out the first one and see how it looks like? image

dsantosferreira commented 1 year ago

The icon on the images I sent is the default one used by the alert component from material UI when the severity attribute is set to "warning". It is probably the "WarningAmber" icon, as you referred. Here is the alert with the filled version of the icon. I prefer the outlined one but tell me what you think!

image

Naapperas commented 1 year ago

The icon on the images I sent is the default one used by the alert component from material UI when the severity attribute is set to "warning". It is probably the "WarningAmber" icon, as you referred. Here is the alert with the filled version of the icon. I prefer the outlined one but tell me what you think!

image

Honestly, I prefer the filed version of the icon.

BrunoRosendo commented 1 year ago

The icon on the images I sent is the default one used by the alert component from material UI when the severity attribute is set to "warning". It is probably the "WarningAmber" icon, as you referred. Here is the alert with the filled version of the icon. I prefer the outlined one but tell me what you think!

image

I do think the filled version looks more like the remaining icons we use (from what I recall, but feel free to check it out)

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 94.84% and project coverage change: +0.52% :tada:

Comparison is base (0cab005) 89.19% compared to head (23032fa) 89.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #309 +/- ## =========================================== + Coverage 89.19% 89.71% +0.52% =========================================== Files 177 180 +3 Lines 3434 3530 +96 Branches 866 890 +24 =========================================== + Hits 3063 3167 +104 + Misses 371 363 -8 ``` | [Files Changed](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP) | Coverage Δ | | |---|---|---| | [...omponents/Apply/Company/ApplicationConfirmation.js](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvQXBwbHkvQ29tcGFueS9BcHBsaWNhdGlvbkNvbmZpcm1hdGlvbi5qcw==) | `100.00% <ø> (ø)` | | | [...ponents/Offers/Form/form-components/offerStyles.js](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvT2ZmZXJzL0Zvcm0vZm9ybS1jb21wb25lbnRzL29mZmVyU3R5bGVzLmpz) | `100.00% <ø> (ø)` | | | [src/components/Offers/New/CreateOfferForm.js](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvT2ZmZXJzL05ldy9DcmVhdGVPZmZlckZvcm0uanM=) | `24.00% <ø> (ø)` | | | [...view/Applications/ApplicationsReviewTableSchema.js](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvUmV2aWV3L0FwcGxpY2F0aW9ucy9BcHBsaWNhdGlvbnNSZXZpZXdUYWJsZVNjaGVtYS5qcw==) | `100.00% <ø> (ø)` | | | [src/utils/analytics/constants.js](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL3V0aWxzL2FuYWx5dGljcy9jb25zdGFudHMuanM=) | `100.00% <ø> (ø)` | | | [...omponents/Apply/Company/CompanyApplicationUtils.js](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvQXBwbHkvQ29tcGFueS9Db21wYW55QXBwbGljYXRpb25VdGlscy5qcw==) | `83.33% <75.00%> (-16.67%)` | :arrow_down: | | [src/pages/CompanyOffersManagementPage.js](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL3BhZ2VzL0NvbXBhbnlPZmZlcnNNYW5hZ2VtZW50UGFnZS5qcw==) | `88.88% <83.33%> (+55.55%)` | :arrow_up: | | [src/components/utils/Alert.js](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvdXRpbHMvQWxlcnQuanM=) | `85.71% <85.71%> (ø)` | | | [...omponents/Offers/Form/form-components/OfferForm.js](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvT2ZmZXJzL0Zvcm0vZm9ybS1jb21wb25lbnRzL09mZmVyRm9ybS5qcw==) | `96.77% <100.00%> (+0.85%)` | :arrow_up: | | [src/pages/ValidationPage.js](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL3BhZ2VzL1ZhbGlkYXRpb25QYWdlLmpz) | `100.00% <100.00%> (ø)` | | | ... and [3 more](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/309?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/309/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.