NIAEFEUP / nijobs-fe

[FRONTEND] A platform for companies to advertise their job opportunities to students
GNU General Public License v3.0
23 stars 3 forks source link

Form errors should be made more explicit #313

Closed Process-ing closed 1 year ago

Process-ing commented 1 year ago

Closes #306

Now, when someone tries to submit a new offer or offer edit with errors, the form scrolls automatically to the corresponding field. Screenshot from 2023-03-01 14-49-24 Screenshot from 2023-03-01 14-49-41 Screenshot from 2023-03-01 14-49-48

Process-ing commented 1 year ago

Here's the video exemplifying the scroll: Screencast from 07-03-2023 15:59:19.webm

BrunoRosendo commented 1 year ago

Here's the video exemplifying the scroll: Screencast from 07-03-2023 15:59:19.webm

Looks great!

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 :tada:

Comparison is base (6d13452) 88.97% compared to head (b44a324) 89.01%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #313 +/- ## =========================================== + Coverage 88.97% 89.01% +0.03% =========================================== Files 175 175 Lines 3311 3322 +11 Branches 834 837 +3 =========================================== + Hits 2946 2957 +11 Misses 365 365 ``` | [Impacted Files](https://codecov.io/gh/NIAEFEUP/nijobs-fe/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP) | Coverage Δ | | |---|---|---| | [...s/Offers/Form/form-components/ApplyURLComponent.js](https://codecov.io/gh/NIAEFEUP/nijobs-fe/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvT2ZmZXJzL0Zvcm0vZm9ybS1jb21wb25lbnRzL0FwcGx5VVJMQ29tcG9uZW50Lmpz) | `100.00% <ø> (ø)` | | | [...s/Offers/Form/form-components/IsHiddenComponent.js](https://codecov.io/gh/NIAEFEUP/nijobs-fe/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvT2ZmZXJzL0Zvcm0vZm9ybS1jb21wb25lbnRzL0lzSGlkZGVuQ29tcG9uZW50Lmpz) | `100.00% <ø> (ø)` | | | [...nts/Offers/Form/form-components/IsPaidComponent.js](https://codecov.io/gh/NIAEFEUP/nijobs-fe/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvT2ZmZXJzL0Zvcm0vZm9ybS1jb21wb25lbnRzL0lzUGFpZENvbXBvbmVudC5qcw==) | `100.00% <ø> (ø)` | | | [...ffers/Form/form-components/JobDurationComponent.js](https://codecov.io/gh/NIAEFEUP/nijobs-fe/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvT2ZmZXJzL0Zvcm0vZm9ybS1jb21wb25lbnRzL0pvYkR1cmF0aW9uQ29tcG9uZW50Lmpz) | `81.81% <ø> (ø)` | | | [...fers/Form/form-components/JobStartDateComponent.js](https://codecov.io/gh/NIAEFEUP/nijobs-fe/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvT2ZmZXJzL0Zvcm0vZm9ybS1jb21wb25lbnRzL0pvYlN0YXJ0RGF0ZUNvbXBvbmVudC5qcw==) | `100.00% <ø> (ø)` | | | [...ts/Offers/Form/form-components/JobTypeComponent.js](https://codecov.io/gh/NIAEFEUP/nijobs-fe/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvT2ZmZXJzL0Zvcm0vZm9ybS1jb21wb25lbnRzL0pvYlR5cGVDb21wb25lbnQuanM=) | `100.00% <ø> (ø)` | | | [...s/Offers/Form/form-components/LocationComponent.js](https://codecov.io/gh/NIAEFEUP/nijobs-fe/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvT2ZmZXJzL0Zvcm0vZm9ybS1jb21wb25lbnRzL0xvY2F0aW9uQ29tcG9uZW50Lmpz) | `100.00% <ø> (ø)` | | | [...ents/Offers/Form/form-components/OwnerComponent.js](https://codecov.io/gh/NIAEFEUP/nijobs-fe/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvT2ZmZXJzL0Zvcm0vZm9ybS1jb21wb25lbnRzL093bmVyQ29tcG9uZW50Lmpz) | `100.00% <ø> (ø)` | | | [...s/Form/form-components/PublicationDateComponent.js](https://codecov.io/gh/NIAEFEUP/nijobs-fe/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvT2ZmZXJzL0Zvcm0vZm9ybS1jb21wb25lbnRzL1B1YmxpY2F0aW9uRGF0ZUNvbXBvbmVudC5qcw==) | `100.00% <ø> (ø)` | | | [...orm/form-components/PublicationEndDateComponent.js](https://codecov.io/gh/NIAEFEUP/nijobs-fe/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvT2ZmZXJzL0Zvcm0vZm9ybS1jb21wb25lbnRzL1B1YmxpY2F0aW9uRW5kRGF0ZUNvbXBvbmVudC5qcw==) | `100.00% <ø> (ø)` | | | ... and [9 more](https://codecov.io/gh/NIAEFEUP/nijobs-fe/pull/313?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.