search

NIAEFEUP / nijobs-fe

[FRONTEND] A platform for companies to advertise their job opportunities to students
GNU General Public License v3.0
23 stars 3 forks source link

Show indication that an offer is disabled in the "Offers management" page #321

Closed Process-ing closed 12 months ago

Process-ing commented 1 year ago

Closes #304

At the moment, the code is doing what it should, with the exception that the offer visibility actions are not modifying the chips accordingly (when toggling the visibility, the chips don't change).

From what I have tested, it seems that, for some reason, when the state is modified in the offer visibility actions component, the change only appears inside that component and in none of the rest (like it's just a copy), although I'm using the respective setState. I still need to figure out how to fix this.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 98.48% and project coverage change: +0.12 :tada:

Comparison is base (c9be64e) 89.07% compared to head (692d8a1) 89.19%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #321 +/- ## =========================================== + Coverage 89.07% 89.19% +0.12% =========================================== Files 176 177 +1 Lines 3395 3434 +39 Branches 855 866 +11 =========================================== + Hits 3024 3063 +39 Misses 371 371 ``` | [Impacted Files](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP) | Coverage Δ | | |---|---|---| | [...ents/Company/Offers/Manage/CompanyOffersActions.js](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvQ29tcGFueS9PZmZlcnMvTWFuYWdlL0NvbXBhbnlPZmZlcnNBY3Rpb25zLmpz) | `100.00% <ø> (ø)` | | | [...any/Offers/Manage/CompanyOffersManagementWidget.js](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvQ29tcGFueS9PZmZlcnMvTWFuYWdlL0NvbXBhbnlPZmZlcnNNYW5hZ2VtZW50V2lkZ2V0Lmpz) | `92.95% <96.66%> (+2.57%)` | :arrow_up: | | [...onents/Company/Offers/Manage/CompanyOffersTitle.js](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvQ29tcGFueS9PZmZlcnMvTWFuYWdlL0NvbXBhbnlPZmZlcnNUaXRsZS5qcw==) | `100.00% <100.00%> (ø)` | | | [...ny/Offers/Manage/CompanyOffersVisibilityActions.js](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL2NvbXBvbmVudHMvQ29tcGFueS9PZmZlcnMvTWFuYWdlL0NvbXBhbnlPZmZlcnNWaXNpYmlsaXR5QWN0aW9ucy5qcw==) | `97.91% <100.00%> (ø)` | | | [src/utils/Table/utils.js](https://app.codecov.io/gh/NIAEFEUP/nijobs-fe/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NIAEFEUP#diff-c3JjL3V0aWxzL1RhYmxlL3V0aWxzLmpz) | `94.11% <100.00%> (+0.36%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Process-ing commented 1 year ago

I finally fixed this issue: the setState problem was due to me forgetting to copy the array ;-;

Now, this PR is working. Here's a video of the final result:

Screencast from 15-07-2023 15:32:44.webm