NIAEFEUP / uni

Mobile app designed to help students of the University of Porto to manage their academic life.

GNU General Public License v3.0

46 stars 15 forks source link

Bump Flutter to 3.22 #1242

Closed bartekpacia closed 3 months ago

bartekpacia commented 3 months ago

Just a maintenance PR to keep Flutter up-to-date.

Testing

I run flutter build apk --debug and flutter build apk --release locally, both pass (I used dummy key.properties for the release build).

Review checklist

[ ] Terms and conditions reflect the current change
[ ] Contains enough appropriate tests
[ ] If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
[ ] Properly adds an entry in changelog.md with the change
[ ] If PR includes UI updates/additions, its description has screenshots
[ ] Behavior is as expected
[ ] Clean, well-structured code

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 17%. Comparing base (94410bf) to head (786b863).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #1242 +/- ## ======================================= - Coverage 17% 17% -0% ======================================= Files 229 229 Lines 6961 6965 +4 ======================================= - Hits 1154 1149 -5 - Misses 5807 5816 +9 ```

limwa commented 3 months ago

@LuisDuarte1 any progress on the proguard rules thingy?

If not, I suggest we merge the PR and take care of that in another PR. @DGoiana what do you think?

limwa commented 3 months ago

Also, @bartekpacia please fix conflicts when possible

bartekpacia commented 3 months ago

@limwa rebased and resolved conflicts

LuisDuarte1 commented 3 months ago

@LuisDuarte1 any progress on the proguard rules thingy?

I'm still looking at it, but we can merge this for now, until I look for a more permanent fix, as it blocks the CI from running.

LuisDuarte1 commented 3 months ago

After some investigation, I've concluded that:

javax.annotations has annotations included in the https://jcp.org/en/jsr/detail?id=305, which is a spec of annotations that help with IDEs or other tools to avoid software defects.
com.google.errorprone has annotations related to ErrorProne, a static analyzer with its own set of annotations like above.

These annotations are not reflected at runtime in any shape or form so, it's safe to ignore them (unfortunately, libs cannot specify what to ignore or not on proguard, so we need to do this by hand). I will send a quick PR to ignore them at the package level.