NIAEFEUP / uni

Mobile app designed to help students of the University of Porto to manage their academic life.

GNU General Public License v3.0

43 stars 15 forks source link

fixing password encoding in local storage #1245

Closed DGoiana closed 1 week ago

DGoiana commented 1 week ago

Closes #1244 We were not storing our passwords correctly, so when trying to retrieve it, decode would actually return null

Review checklist

[ ] Terms and conditions reflect the current change
[ ] Contains enough appropriate tests
[ ] If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
[ ] Properly adds an entry in changelog.md with the change
[ ] If PR includes UI updates/additions, its description has screenshots
[ ] Behavior is as expected
[ ] Clean, well-structured code

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 17%. Comparing base (36b0f44) to head (5477255).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #1245 +/- ## ======================================= + Coverage 17% 17% +1% ======================================= Files 229 229 Lines 6952 6952 ======================================= + Hits 1147 1154 +7 + Misses 5805 5798 -7 ```

limwa commented 1 week ago

Yep, I agree. I suggested that on Slack and I think it's the way to go! What do the others think?