search

NIAEFEUP / uni

Mobile app designed to help students of the University of Porto to manage their academic life.
GNU General Public License v3.0
50 stars 18 forks source link

Move aai envs from .env to constants file #1262

Closed thePeras closed 4 months ago

thePeras commented 4 months ago

Closes #1261

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 16%. Comparing base (8322384) to head (440302e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1262 +/- ## ======================================= + Coverage 16% 16% +1% ======================================= Files 233 233 Lines 7219 7214 -5 ======================================= Hits 1139 1139 + Misses 6080 6075 -5 ```
limwa commented 4 months ago

What is the purpose of this PR? Why is this being done?

Personally, I think these values belong in a .env file or something similar.

limwa commented 4 months ago

Or maybe I should've put it this way: can the notifications worker not access the .env file?

thePeras commented 4 months ago

@limwa I can explain in the next meeting, but basically in my attempt to load the .env, which was successful, the functions using the environment's variables still doesn't find the DotEnv instantiation. May theory is the package wasn't created for notifications workers. Also, I tried to explore more packages, but no luck. That's why I propose this way, not ideal, but fast, simple and with no security concerns.