NIAEFEUP / uni

Mobile app designed to help students of the University of Porto to manage their academic life.

GNU General Public License v3.0

50 stars 18 forks source link

refactor: session logic #1283

Closed limwa closed 2 months ago

limwa commented 4 months ago

[ATTENTION. This is the Pull Request Template. Replace the two following lines with the indicated information and delete this one. Do not delete anything else]

Closes #[issue number] [Description of the changes proposed in the pull request. Include steps to replicate the behavior and screenshots if UI is updated]

Review checklist

[ ] Terms and conditions reflect the current change
[ ] Contains enough appropriate tests
[ ] If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
[ ] Properly adds an entry in changelog.md with the change
[ ] If PR includes UI updates/additions, its description has screenshots
[ ] Behavior is as expected
[ ] Clean, well-structured code

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 2.94840% with 395 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (f6e0da3) to head (4d28139). Report is 37 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #1283 +/- ## ======================================== - Coverage 16% 11% -4% ======================================== Files 238 268 +30 Lines 7172 7303 +131 ======================================== - Hits 1078 799 -279 - Misses 6094 6504 +410 ```

limwa commented 2 months ago

Don't merge yet, there is an active discussion in slack