search

NIAEFEUP / website-niaefeup-frontend

The frontend of the website for NIAEFEUP.
2 stars 0 forks source link

Fix/background hexagon #275

Closed MRita443 closed 4 months ago

MRita443 commented 5 months ago

Closes #146

Adds a negative z-index to the BackgroundHexagon component, as to fix it overlapping other components and interfering with functioning of buttons and touch events.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (b820ff3) to head (f75dcbb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #275 +/- ## ============================================ + Coverage 95.21% 100.00% +4.78% ============================================ Files 20 2 -18 Lines 188 16 -172 Branches 38 4 -34 ============================================ - Hits 179 16 -163 + Misses 9 0 -9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Naapperas commented 4 months ago

I checked the Netlify site and there are no new deploys since February 6, I don't know what happened but it might be best to create a new PR and let Netlify figure themselves out with the new branch @MRita443

MRita443 commented 4 months ago

The netifly previews are still not working for this (or any newer, for that case) prs. However, this a really minor change and urgent for proper testing of many other prs, so it will be merged