search

NIAEFEUP / website-niaefeup-frontend

The frontend of the website for NIAEFEUP.
2 stars 0 forks source link

Migrate to sveltekit 2 and update deps #276

Closed jpnsantoss closed 2 months ago

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 1.01%. Comparing base (8497122) to head (2fb1530).

:exclamation: Current head 2fb1530 differs from pull request most recent head e7fe5ab. Consider uploading reports for the commit e7fe5ab to get more accurate results

Files Patch % Lines
src/lib/layout/Footer.svelte 0.00% 9 Missing :warning:
src/routes/+layout.svelte 0.00% 3 Missing :warning:
src/lib/layout/BackgroundHexagon.svelte 0.00% 2 Missing :warning:
src/lib/layout/Sidebar.svelte 0.00% 2 Missing :warning:
src/lib/notifications/Snackbar.svelte 0.00% 2 Missing :warning:
svelte.config.js 0.00% 2 Missing :warning:
src/lib/error-page/Button.svelte 0.00% 1 Missing :warning:
src/routes/+error.svelte 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #276 +/- ## =========================================== - Coverage 100.00% 1.01% -98.99% =========================================== Files 2 49 +47 Lines 16 1584 +1568 Branches 4 51 +47 =========================================== Hits 16 16 - Misses 0 1521 +1521 - Partials 0 47 +47 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MRita443 commented 3 months ago

Currently, this PR is missing two things: @LuisDuarte1 is updating the storybook tests CI to run locally but it is running infinitely. The dependencies upgrade part seems to be done already, but it generating some overriding peer dependency warnings regarding vite that we would like to try to get rid of. @jpnsantoss experimented with peerDependencies but to no avail so far.

LuisDuarte1 commented 3 months ago

The CI is now running the storybook web server locally, however, it's not an optimal CI setup, we could cache the playwright dependencies and cache the storybook-static folder in case there aren't any changes. This is not a priority because we have unlimited minutes so I'll open an issue to optimize the CI.

BrunoRosendo commented 3 months ago

The CI is now running the storybook web server locally, however, it's not an optimal CI setup, we could cache the playwright dependencies and cache the storybook-static folder in case there aren't any changes. This is not a priority because we have unlimited minutes so I'll open an issue to optimize the CI.

It's nice that we have unlimited minutes but it's still a much better dev experience to have the folder cached, it should be a priority imo