Closed gtsueng closed 4 months ago
I made a new release on staging. It should be fixed.
variableMeasured
field appears to still be just a link of urls, are we not able to pull in the name of term?
Per discussion on 2024.02.21, PubTator is still greedily assuming credit for these fields for links ingested via the DDE. This behavior needs to be changed.
Awesome! It looks like variableMeasured
is pulling and displaying terms now! Can we do this for keywords
? See https://data-staging.niaid.nih.gov/resources?id=DDE_9142024b72770a67
Thanks for catching that. Ill get that done today.
The improvements are on available on staging
Issue Name
DDE DefinedTerms
curatedBy
fixIssue Description
The records ingested via the DDE are generally manually curated, so it is strange that fields where the expected type is DefinedTerm is being treated as if they were augmented. We should only consider them augmented if the value for the field is a non-URI text.
Suggested fix- Have a separate handler for URIs
keywords
,measurementTechnique
,variableMeasured
which may potentially have URI values when ingested via DDE, but currently there is no standardization method to apply if these fields have a free text value.curatedBy
value (if it's required), use NIAID SysBio (if the record is coming from the NIAID SysBio portal on the DDE), or NIAID Data Ecosystem (if the record is coming from the NDE portal on the DDE). @jal347 should be familiar with such a conditional as he has created one for theincludedInDataCatalog
field for the DDE parserFields that are potentially affected (i.e. - could potentially have URI values for conversion to DefinedTerm object):
species
infectiousAgent
healthCondition
measurementTechnique
keywords
variableMeasured
topicCategory
Issue Example
TB Portals is a resource catalog that was added via the DDE:
https://discovery.biothings.io/dataset/9142024b72770a67
As seen in this image, the fields
infectiousAgent
,healthCondition
, andspecies
already have ontology uri values so we should not consider them augmented fields, and they should NOT be consideredcuratedBy
PubTator, or BioThings. They were curated to begin with.However, they currently display in the ecosystem (staging for this example, but most records from NIAID SysBio/DDE in production have the same issue) as being curatedBy PubTator or BioThings. Here is the same record as it appears in data-staging.niaid.nih.gov:
https://data-staging.niaid.nih.gov/resources?id=DDE_9142024b72770a67
Related WBS task
For internal use only. Assignee, please select the status of this issue
Status Description
No response