NIAID-Data-Ecosystem / nde-portal

Discovery platform to find NIAID-related datasets and tools
Apache License 2.0
3 stars 1 forks source link

Updating resource ID in the URL #235

Closed candicecz closed 1 month ago

candicecz commented 2 months ago

Per our discussion on 4/24/2024, we decided that certain improvements can be made to the resource id in the API and it's handling in the front-end so as to follow best practices for URL naming conventions. This change also improves SEO search engines are not always handling URLS with case sensitivity.

Action items:

Related WBS task

https://github.com/NIAID-Data-Ecosystem/nde-roadmap/issues/33

gtsueng commented 2 months ago

Note that the DS_ in VEuPathDB identifiers appear to be case sensitive: https://data.niaid.nih.gov/resources?id=veupathdb_DS_0273077ad5

In VEuPathDB: https://veupathdb.org/veupathdb/app/record/dataset/DS_0273077ad5

Will fail: https://veupathdb.org/veupathdb/app/record/dataset/ds_0273077ad5

candicecz commented 2 months ago

@gtsueng We use the url field to direct the user to the dataset. So as long as we don’t transform the id in the url property, it should be ok.

gtsueng commented 1 month ago

We are marking this issue as pending close out and will close it after a week if no new comments or concerns arise