[User Interface: Redesign]: Additional UI recommendations from OCGR

gtsueng commented 4 months ago

Issue Name

Additional UI recommendations from OCGR

Issue Description

See related issue #146 for additional details

[x] Thank you for adding ROR IDs and links to RePORTER. This will be helpful for NIAID users. Please update to how IDs are displayed on resource cards to be consistent with OCGR recommendations such that anything that is looks like a button should be clickable. For example, either update the ROR ID (under the funder name) to act as a link (because it currently looks like a button) OR change the aesthetic of the ROR ID so that is visually different from the aesthetic around the RePORTER link and does not appear clickable
[x] For some records, the funding information has grant id's which are linked to NIH reporter (as seen in above), but for other records not in LINCS, the ID's appear the same, but are NOT linked. Ensure that linked ids appear differently from unlinked IDs:
- [x] Ensure that the funding helper function is run on ResourceCatalogs and every repository so that the identifiers are linked to NIH RePORTER whenever possible and that Funding organizations have either a ROR ID or CrossRef ID whenever possible so that the metadata is formatted consistently and/or has consistent information
- [x] The front end display of funding information follows OCGR recommendations ensuring that buttons have an appropriate action (like linking to RePORTER) or ensuring that non-interactive elements don't look like buttons
[x] The term ID is used for both the ‘funding name’ and ‘funding’ column. Consider more specific terms to identify each item.
[x] Other examples of non-interactive elements that look like button distinguished only by the link out text style and link arrow icon

Issue Discussion

This request was made by the NIAID/ODSET team in an email dated 2024.06.04

Mockup URL

No response

WCAG Compliance Check

[x] The ui changes are not expected to significantly affect WCAG compliance (ex- wording changes)
[ ] The ui changes have visual elements which have yet to be tested for WCAG compliance
[ ] The ui changes have visual elements which have been tested for WCAG compliance
[ ] The ui changes have passed all checks for WCAG compliance

Related WBS task

[X] Check here if the ui change is centered on the look and feel (https://github.com/NIAID-Data-Ecosystem/nde-roadmap/issues/52)
[ ] Check here if the ui change includes new features (https://github.com/NIAID-Data-Ecosystem/nde-roadmap/issues/53)
[X] Check here if the ui change was suggested by the NIAID team (https://github.com/NIAID-Data-Ecosystem/nde-roadmap/issues/2)

For internal use only. Assignee, please select the status of this issue

[ ] Not yet started
[ ] In progress
[ ] Blocked
[ ] Will not address

Status Description

No response

UI change status check list

[ ] This ui change has yet to be discussed between NIAID, Scripps, Leidos
[X] This ui change has been discussed/reported between NIAID, Scripps, Leidos
[ ] This ui change has been mocked up
[ ] This ui change has been implemented on Dev
[x] This ui change has been approved for Staging
[x] This ui change has been implemented on Staging
[ ] This ui change has been approved for Production
[ ] This ui change has been implemented on Production

candicecz commented 2 months ago

This feedback has been incorporated into the staging instance. You may view an example here and I've also attached a screenshot reflecting this change. snap

gtsueng commented 2 months ago

@hartwickma @lisa-mml @rshabman @sudvenk

The requested changes made via an email dated: 2024.06.04 (subject line: RE: Brief Portal feedback items for Scripps) are now on staging; thus I'm changing the status of this issue to Review requested - Staging

The Ask: We seek approval to move these changes to production

lisa-mml commented 2 months ago

@gtsueng - thanks for updating the identifier aesthetics to clarify links out. Can you provide more information about the "Funder ID" source (e.g., ROR ID, Crossref::funder_identifier, something else?)?

gtsueng commented 2 months ago

@lisa-mml -- For the RePORTER-normalized funder IDs -- most likely Crossref IDs as ROR IDs are URIs. For any non-normalized funder IDs, anything goes.

With CrossRef's intention to deprecate the CrossRef Open Funder Registry, we plan to migrate to using only ROR IDs in the future. We are awaiting input from the NIAID team on how to best handle the funder information from NIH RePorter (https://github.com/NIAID-Data-Ecosystem/niaid-feedback/issues/143). Once the best path forward has been decided, we'll update the funding helper to use ROR IDs (which will be URIs and therefore appear as links).

In any case, the front-end display/changes that @candicecz made should reflect the future back-end changes seamlessly, as all the info is populated based on the metadata and not manually encoded on the front end.

hartwickma commented 2 months ago

Hi @gtsueng this sounds like a great discussion item to add to the discussion of #143 'help with funder mapping' As we highlighted in our response to issue #143: Hi @gtsueng, please bring this as an agenda item in an upcoming bi-weekly meeting.

gtsueng commented 1 month ago

@hartwickma @lisa-mml @rshabman @sudvenk

The UI changes have been made an are now on production. I am marking this issue as pending close out as it has been addressed on the front-end. Note that there may be back-end improvements needed for this issue to appear to be fully addressed (i.e. - for ROR IDs to appear for resource catalogs or for migration to cross ref ids), but those are already separate issues that can be tracked on the corresponding issue:

NIAID-Data-Ecosystem / nde-portal