search

NICMx / Jool

SIIT and NAT64 for Linux
GNU General Public License v2.0
326 stars 66 forks source link

Jool-3.2.2 unzips without subdir #127

Closed mcr closed 9 years ago

mcr commented 9 years ago 
knothole-[/emmjay/builds] mcr 1219 %unzip -l Jool-3.2.2.zip | sed 10q
Archive:  Jool-3.2.2.zip
  Length      Date    Time    Name
 ---------  ---------- -----   ----
    1777  2014-10-24 16:10   abbreviations.txt
  35147  2014-10-24 16:10   COPYING
         0  2014-10-24 16:10   doc/
     919  2014-10-24 16:10   doc/README.md
        0  2014-10-24 16:10   doc/dev/

The instructions at: http://www.jool.mx/mod-install.html suggest that a subdirectory Jool-3.2.2 would be created, and I'd much prefer that it do that too. "git archive --prefix=" is your friend here.

ydahhrk commented 9 years ago

Thank you.

I'm not sure how people is going to react to official releases changing checksums, so I'm actually not that comfortable applying this to the already existing zips.

On the other hand, I have no problems with including a prefix in upcoming releases (3.2.3+, 3.3.0+, etc). Is this reasonable?

mcr commented 9 years ago

fixes for the next release will be great.

ydahhrk commented 9 years ago

Applied to the 3.2.3 and 3.3.0 zips and updated the release protocol.