NICMx / Jool

SIIT and NAT64 for Linux
GNU General Public License v2.0
320 stars 66 forks source link

Make user-space utility exit unsuccessfully when encountering errors #184

Closed toreanderson closed 8 years ago

toreanderson commented 8 years ago

I botched the upgrade to v3.4.0 on one of my BRs, getting the kernel module and the user-space utility out of sync. Therefore Jool ended up in an unconfigured state. The unfortunate thing is that the start-up scripts incorrectly believed that Jool was initialised just fine, and therefore proceeded to start up BIRD to advertise routes to the various IP pools to the rest of the network. This caused blackholing of traffic.

The problem would not have occurred if the user-space app had exited unsuccessfully when encountering any error.

$ /usr/bin/jool_siit -e 
Error: (Error code: 22)
  (empty)
$ echo $?
0
$ dmesg | tail -n 1
[  461.694810] SIIT Jool ERROR (validate_version): Version mismatch. The kernel module is 3.3.4.0, but the userspace application is 3.3.2.12. Please update Jool's userspace application.
ydahhrk commented 8 years ago

Sorry :/