Closed andreasfink closed 1 year ago
this worked around this:
cp /usr/src/linux-headers-6.1.0-0.deb11.7-common/include/linux/stdarg.h /usr/src/linux-headers-6.1.0-0.deb11.7-common/include/stdarg.h
Alternatively, just remove the #include
line.
For some reason, later Jool versions are of the mind that stdargs.h
is not needed on kernels 5.15+:
But Jool 4.1.9 removed the dependency entirely. And that seems to be the right solution, because 4.1.5 compiles fine for me on kernel 5.10, without #include <stdargs.h>
. It seems to be a remnant from very old code.
Also, kernel 6.1 wasn't supported until Jool 4.1.9, so your workaround surprises me.
So the real solution is to upgrade to a more recent Jool version. Unfortunately, Debian doesn't really allow me to push an update to stable, so you might want to use the standalone.
Tentatively closing this.
Unfortunately, Debian doesn't really allow me to push an update to stable
What makes you think so? You're the maintainer in Debian too, right? You just have to add a patch to the package from stable, get approval from the release team and have your sponsor upload to stable https://www.debian.org/doc/manuals/developers-reference/pkgs.en.html#special-case-uploads-to-the-stable-and-oldstable-distributions.
IIRC users can then get it by adding a sources.list line for "stable-proposed-updates" even before the point release happens.
What makes you think so? You're the maintainer in Debian too, right? You just have to add a patch to the package from stable, get approval from the release team and have your sponsor upload to stable
Hmmm. It seems this is reserved for important bugs. I don't know if this issue qualifies.
I think it would be difficult to fulfill the following requirement:
- The bug should be of severity "important" or higher.
And also maybe
- (...) you should be able to explain what testing it has had.
Also, the latest version has changed since this issue was filed. From andreasfink's opening comment, it seems Debian's stable
Jool used to be 4.1.5. Now it's 4.1.9. Therefore, it seems this bug is already fixed in Debian now.
Fair enough, just wanted to make you aware that you have options for fixes in stable :)
The bug should be of severity "important" or higher.
"important": a bug which has a major effect on the usability of a package, without rendering it completely unusable to everyone. (https://www.debian.org/Bugs/Developer#severities)
Sure that applies, no problem.
(...) you should be able to explain what testing it has had.
"I tried it and it works" is totally acceptable ;) The impact is pretty limited after all since jool is rather niche. Too little testing is mainly a blocker for "core" packages that everyone (or at least a lot of people) are going to have on their systems. I'm pretty sure anyone running DKMS modules is going to be perfectly able to send bugreports if needed :)
--Daniel
Oh! almost forgot to mention, there's also backports. You can upload the latest version of jool to the backports repo as soon as it's installed in unstable. Then stable users can opt-in to install it from there if needed. Happy to help with figuring out the workflow if that's something you want to do.
Fair enough, just wanted to make you aware that you have options for fixes in stable :)
Ah. Thank you very much.
Yeah, I guess I had honestly blurred these options out of my toolset at this point.
Oh! almost forgot to mention, there's also backports. You can upload the latest version of jool to the backports repo as soon as it's installed in unstable. Then stable users can opt-in to install it from there if needed. Happy to help with figuring out the workflow if that's something you want to do.
Ok, I guess I'll give it a shot for version 4.1.10-2, since I'm planning to push it soon.
See https://backports.debian.org/Contribute/ there is some procedures to be aware of. I haven't uploaded backports as a DM directly yet only via DD sponsor. I'm not sure the usual ftp-master dm.txt list applies to backports, but IIRC you upload through a sponsor anyway so it should be fine.
The package has to be migrated to testing before the backports upload I had that wrong, but still. Not too much of a delay compared to "next Debian release" :)
Error! Bad return status for module build on kernel: 6.1.0-0.deb11.6-arm64 (aarch64) Consult /var/lib/dkms/jool-dkms/4.1.5/build/make.log for more information. dpkg: error processing package jool-dkms (--configure): installed jool-dkms package post-installation script subprocess returned error exit status 10 Errors were encountered while processing: jool-dkms E: Sub-process /usr/bin/dpkg returned an error code (1)
[root@de1 afink]# more /var/lib/dkms/jool-dkms/4.1.5/build/make.log DKMS make.log for jool-dkms-4.1.5 for kernel 6.1.0-0.deb11.6-arm64 (aarch64) Fri 28 Apr 2023 08:03:40 PM CEST make: Entering directory '/usr/src/linux-headers-6.1.0-0.deb11.6-arm64' CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/rfc7915/4to6.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/rfc7915/6to4.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/rfc7915/common.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/rfc7915/core.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/address_xlat.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/dev.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/kernel_hook_netfilter.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/kernel_hook_iptables.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/log.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/address.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/atomic_config.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/icmp_wrapper.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/init.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/ipv6_hdr_iterator.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/joold.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/packet.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/rfc6052.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/rtrie.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/stats.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/types.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/translation_state.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/route_out.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/skbuff.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/core.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/error_pool.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/timer.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/trace.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/wkmalloc.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/wrapper-config.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/wrapper-global.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/wrapper-types.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/xlator.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/steps/send_packet.o CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/nl/address.o /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/error_pool.c:3:10: fatal error: stdarg.h: No such file o r directory 3 | #include
| ^
~~~~~ compilation terminated. CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/nl/atomic_config.o make[1]: [/usr/src/linux-headers-6.1.0-0.deb11.6-common/scripts/Makefile.build:255: /var/lib/dkms/jool- dkms/4.1.5/build/src/mod/common/error_pool.o] Error 1 make[1]: Waiting for unfinished jobs.... CC [M] /var/lib/dkms/jool-dkms/4.1.5/build/src/mod/common/nl/attribute.o make: *** [/usr/src/linux-headers-6.1.0-0.deb11.6-common/Makefile:2030: /var/lib/dkms/jool-dkms/4.1.5/build /src/mod/common] Error 2 make: Leaving directory '/usr/src/linux-headers-6.1.0-0.deb11.6-arm64'[root@de1 afink]# locate stdarg.h /usr/include/c++/10/tr1/stdarg.h /usr/lib/gcc/aarch64-linux-gnu/10/include/stdarg.h /usr/lib/llvm-11/lib/clang/11.0.1/include/stdarg.h /usr/src/linux-headers-6.1.0-0.deb11.6-common/include/linux/stdarg.h
[root@de1 afink]# uname -a Linux de1 6.1.0-0.deb11.6-arm64 #1 SMP Debian 6.1.15-1~bpo11+1 (2023-03-16) aarch64 GNU/Linux