At CppCon 2015, the C++ standards committee open sourced a guideline for writing good modern C++. I think it would be a good idea for stateline to follow it.
As a result, some code cleanup may be required. From the top of my head, these are some of the places where stateline doesn't conform to the guidelines
Use uniform initialization (the initializer list style)
Use std::unique_ptr for owning pointers, and raw pointers for non-owning pointers. (This is violated by many of the zmq::context_ts).
I.4: Make interfaces precisely and strongly typed
I.24: Avoid adjacent unrelated parameters of the same type (nstacks and nchains often get confused)
And many more
This is not really a high priority thing, but we should at least conform to the guidelines when we're writing new code and try to make old code conform if we happen to modify it.
At CppCon 2015, the C++ standards committee open sourced a guideline for writing good modern C++. I think it would be a good idea for stateline to follow it.
As a result, some code cleanup may be required. From the top of my head, these are some of the places where stateline doesn't conform to the guidelines
std::unique_ptrfor owning pointers, and raw pointers for non-owning pointers. (This is violated by many of thezmq::context_ts).This is not really a high priority thing, but we should at least conform to the guidelines when we're writing new code and try to make old code conform if we happen to modify it.