search

NIEHS / GeoTox

Open-source software for connecting spatiotemporal exposure to individual and population-level risk
https://niehs.github.io/GeoTox/
Other
2 stars 0 forks source link

break up calc_concentration_response.R into individual functions #24

Closed kyle-messier closed 7 months ago

kyle-messier commented 7 months ago

@SkylarMarvel Was looking to write tests for calc_concentration_response.R and am thinking individual functions for GCA/IA response and HQ would be cleaner. Is there a major reason to keep it as one big one?

SkylarMarvel commented 7 months ago

@Spatiotemporal-Exposures-and-Toxicology They all use the same input values for Ci, tp and AC50, so having them all computed at the same time makes sense. Also, some of the downstream functions expect the currently output data.frame with multiple fits. If desired, we could add flags for computing only certain values, but I would avoid splitting it into multiple functions.

kyle-messier commented 7 months ago

@SkylarMarvel Ok, that makes sense. No need for flags atm. I will close this issue then.