Sciome Update 1/10/2024

NIEHS / PrestoGP

Penalized Regression on Spatiotemporal Outcomes using Gaussian Processes a.k.a. PrestoGP

https://niehs.github.io/PrestoGP/

0 stars 0 forks source link

Sciome Update 1/10/2024 #44

Closed ericbair-sciome closed 5 months ago

ericbair-sciome commented 5 months ago

This release contains a number of improvements and bug fixes. The main enhancements are listed below:

Univariate models (both Vecchia and full) are now working correctly.
The code base has been simplified, with many redundant functions removed.
The testing code is much more extensive with coverage for all critical functions. All tests are passing on all platforms we tested.

kyle-messier commented 5 months ago

@ericbair-sciome Let me know if it would be helpful to go ahead and merge into main without the tests passing. We would do that if there are key updates (which clearly there are) and then isolate the test checks/passing in a separate pull request.

ericbair-sciome commented 5 months ago

Go ahead and accept the pull request. I think this is a GitHub issue. All of the testthat tests pass when you run devtools::test() from within R. Maybe @shail-choksi has some idea what is causing his and how to fix it. If not, I'll do some research myself. (The R CMD check tests are going to fail for the time being regardless due to a number of issues that I haven't had time to fix yet, such as incomplete documentation. That is next on my list to fix.)