NIEHS / PrestoGP

Penalized Regression on Spatiotemporal Outcomes using Gaussian Processes a.k.a. PrestoGP
https://niehs.github.io/PrestoGP/
0 stars 0 forks source link

Pull request #37: Added documentation. Added RandomFields data sets. Fixed R CMD issues #51

Closed sciome-bot closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (8ffb20b) 78.98% compared to head (95fef8c) 82.14%. Report is 6 commits behind head on main.

Files Patch % Lines
R/PrestoGP_Util_Functions.R 74.07% 7 Missing :warning:
R/PrestoGP_Model.R 78.57% 6 Missing :warning:
R/PrestoGP_Multivariate_Vecchia.R 66.66% 2 Missing :warning:
R/PrestoGP_CreateU_Multivariate.R 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #51 +/- ## ========================================== + Coverage 78.98% 82.14% +3.15% ========================================== Files 9 9 Lines 1280 1271 -9 ========================================== + Hits 1011 1044 +33 + Misses 269 227 -42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ericbair-sciome commented 4 months ago

It looks like our bot automatically created this pull request. The main three changes in this version are the following:

1) Documentation now exists for all user-facing functions. 2) R CMD check should be passing. (It looks like the vignette is causing it to fail on the GitHub server. I created an issue about that.) 3) Binomial regression is now implemented.

There are a few other minor optimizations and bug fixes as well. It looks like I accidentally created a few lint issues while doing this. I will try to push a quick patch to fix those.

ericbair-sciome commented 4 months ago

I pushed a minor fix this morning that removed the vignette and fixed a couple linting issues that I overlooked. It looks like all of our tests are passing now. Hooray!

kyle-messier commented 4 months ago

@sciome-bot @ericbair-sciome @shail-choksi @sigmafelix @brian-bk22 image

kyle-messier commented 4 months ago

@shail-choksi @ericbair-sciome Y'all can merge!