search

NIEHS / RGCA

Reflected Generalized Concentration Addition approach for prediction of combined chemical mixtures responses. See `citation` for appropriate citation in using this package.
https://niehs.github.io/RGCA/
0 stars 0 forks source link

Lower Cyclometric Complexity #11

Closed dzilber closed 5 months ago

dzilber commented 7 months ago

There are a few functions that have high test complexity:

  1. hill_invs_factry() in helper_calculators.R
  2. run_comparison_simulation() in DP_simulation_study.R
  3. RE_MCMC_fit() in RE_dose_response_MCMC.R
  4. generate_mixture_subset() in tox21_prep_data.R

The hill function is describing function behavior on different partitions of a parameter space: difficult to fix. The MCMC fit function is running MCMC iterations and may require special testing procedures. The other two functions should be amenable to lower complexity.

dzilber commented 5 months ago

The inverse function factory was modified to have lower complexity in an earlier commit. The remaining functions are not intended as package functionality per #14 and will be moved to one of the external folders. Closing ticket.