search

NIEHS / amadeus

https://niehs.github.io/amadeus/
Other
7 stars 1 forks source link

1.0.1 #114

Closed mitchellmanware closed 3 months ago

mitchellmanware commented 4 months ago

@kyle-messier It seems like the checks are not consistently handling the license stub note. Some have not problem with the "License: MIT + file LICENSE" line (https://github.com/NIEHS/amadeus/actions/runs/10153735900/job/28077640433) whereas others throw notes for this line or "License: MIT" only (https://github.com/NIEHS/amadeus/actions/runs/10153752290/job/28077688790). ChatGPT said what we have now should be fine so I am not entirely sure how to fix this one.

I also updated the vignette to not run live code and return pre-written messages to mimic output, as the reading of .nc files for the workflow vignette was causing the checks to run indefinitely. Not a perfect solution but hopefully good enough for now, and keeps the package size reasonable (4.7 Mb).

I will resubmit this version to CRAN shortly, but I will wait to pull into main until accepted.

kyle-messier commented 4 months ago

@mitchellmanware How do the LICENSE updates do with the winbuilder check? If the --as-cran checks pass, then we should be all good. I'm also fine with submitting and seeing what gets kicked back and dealing with it that way. Thanks!

kyle-messier commented 3 months ago

@mitchellmanware I'd say let's resubmit to CRAN and see what happens. Perhaps there will be 1 or 2 unresolved notes. Regardless, it would be good to reset the resubmission clock.