search

NIEHS / amadeus

https://niehs.github.io/amadeus/
Other
7 stars 1 forks source link

1.0.7 #122

Closed mitchellmanware closed 2 months ago

kyle-messier commented 3 months ago

@mitchellmanware The url in the DESCRIPTION should be changed to our pkgdown site location (https://niehs.github.io/amadeus/) so that shows up on the CRAN url

mitchellmanware commented 3 months ago

@kyle-messier Got it - I will udpate. Is that worth a resubmission?

I have also added the download badge and working on a CRAN version badge

kyle-messier commented 3 months ago

@mitchellmanware No, we'll undoubtedly find a whole host of things to update, so let's just wait until we have a decent collection of updates to resubmit.

mitchellmanware commented 3 months ago

The use of message() instead of print() in the error messages for download_data() changed the format of the output. Although the same message is sent to the user's console, it is not registered as the error message by testthat::expect_error. The expected error messages associated with download_data() tests (when acknowledgement = FALSE and directory_to_save = NULL) have been removed from the test. The tests still ensure the function fails when it is supposed to, but does not required a specific message.

mitchellmanware commented 3 months ago

Updated error handling in download_data, process_covariates, and calc_covariates to report error, error-generating arguments, and message using one stop() statement.

mitchellmanware commented 2 months ago

1.0.6 --> 1.0.7 yes?

Yes, updated to 1.0.7 for resubmission