search

NIEHS / amadeus

https://niehs.github.io/amadeus/
Other
7 stars 1 forks source link

0.1.0 #13

Closed sigmafelix closed 9 months ago

codecov[bot] commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6000bd0) 93.77% compared to head (b88ed8b) 94.45%.

Files Patch % Lines
R/calculate_covariates.R 98.87% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #13 +/- ## ========================================== + Coverage 93.77% 94.45% +0.68% ========================================== Files 6 6 Lines 2056 2182 +126 ========================================== + Hits 1928 2061 +133 + Misses 128 121 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sigmafelix commented 9 months ago

To note: @eva0marques https://github.com/Spatiotemporal-Exposures-and-Toxicology/amadeus/actions/runs/7936474332/job/21671826629?pr=13#step:6:841

dplyr::select() should be used with dplyr::all_of() or dplyr::any_of(). Please consider reflecting the syntax in future commits. Thanks!

All tests passed and failing in the Windows runner persists. I will merge this PR.

eva0marques commented 9 months ago

Yes I've seen this problem, I will try to fix it but it does not the same task than I want to do.