search

NIEHS / amadeus

https://niehs.github.io/amadeus/
Other
7 stars 1 forks source link

rename `calc_sedc` #133

Closed mitchellmanware closed 1 month ago

mitchellmanware commented 1 month ago

Reviewer 1, Other Comment 11 Line 12, page 13: The calc_sedc function name may be misleading. All of the other calc_ functions are related to different data sources, while this one is related to the calculation of the sum of exponentially decaying contribution function. I would suggest to rename its prefix.

mitchellmanware commented 1 month ago

Propose to change to sum_edc to still reflect "sum of exponentially decaying contribution" function while retaining the prefix_suffix function naming convention.

mitchellmanware commented 1 month ago

https://github.com/NIEHS/amadeus/commit/7ac41bd07582bfba24d33e9c544de682b5e61bce