search

NIEHS / amadeus

https://niehs.github.io/amadeus/
Other
7 stars 1 forks source link

`calculate_modis` #140

Open mitchellmanware opened 3 weeks ago

mitchellmanware commented 3 weeks ago

Update calculate_modis_par to single calculate_modis function. The additional *_par function is confusing and unnecessary as the rest of the functions are already built to handle multiple dates. Parallelization functionality will be retained.

mitchellmanware commented 3 weeks ago

Description of the calculate_modis_daily function will be transitioned to a primarily internal/auxiliary function.

kyle-messier commented 3 weeks ago

Additionally, tying the time range of calculate_modis to the downloaded files is not in alignment with our other datasets. It would be great to be able to summarize over different time periods besides daily. Would that be a significant departure from the current function structure?

mitchellmanware commented 3 weeks ago

Do you mean instead of accepting only date = c("2020-01-01, "2020-12-31") it also accepts year = 2020 or time = "April 2020"?

sigmafelix commented 1 week ago

@mitchellmanware @kyle-messier Besides the temporal scoping for summarization, #144 removed future and future.apply dependency, and calculate_modis_par is renamed to calculate_modis.