search

NIEHS / amadeus

https://niehs.github.io/amadeus/
Other
4 stars 2 forks source link

Adopting linter #2

Closed sigmafelix closed 6 months ago

sigmafelix commented 6 months ago

My PR's workflows are adopted from chopin's. Do we want to use linter for amadeus?

kyle-messier commented 6 months ago

For sure!

image

kyle-messier commented 6 months ago

@sigmafelix @mitchellmanware

I think an initial grace period from branch protection rules (ie. mandatory tests like pull requests, etc.) is okay. Once you have the basic stuff transferred over, let me know, and then I'll add the rules

sigmafelix commented 6 months ago

@Spatiotemporal-Exposures-and-Toxicology I will add a linter as well. We will need to work on system-specific problems (i.e., related to command-line tools) as the tests passed only in linux runners.

mitchellmanware commented 6 months ago

@sigmafelix I had not considered that before, but yes, I will have to create additional functions for system detection + system-specific command writing.

For linting, implementing on all pushes could help identify lint related issues earlier in branches and avoid PRs being hung up on whitespace or indentation issues.

sigmafelix commented 6 months ago

@Spatiotemporal-Exposures-and-Toxicology @mitchellmanware The errors seem to be related to settings in Action runner images. I am looking into it. I will enable linter in the next push. Thanks!