search

NIEHS / amadeus

https://niehs.github.io/amadeus/
MIT License
2 stars 2 forks source link

Patch comparison test #3 #56

Closed mitchellmanware closed 3 months ago

mitchellmanware commented 3 months ago

Fail case successful (https://github.com/NIEHS/amadeus/actions/runs/8473409463/job/23217644149)

mitchellmanware commented 3 months ago

Finally running for success and fail cases 🙏 Updates the cov_current.Rout file on the gh-pages branch if patch is greater or equal to current. Fails otherwise.

kyle-messier commented 3 months ago

Finally running for success and fail cases 🙏 Updates the cov_current.Rout file on the gh-pages branch if patch is greater or equal to current. Fails otherwise.

Awesome work and perseverance!

mitchellmanware commented 3 months ago

@kyle-messier First testthat try (https://github.com/NIEHS/amadeus/pull/56/commits/de9d6899df2c613c5dbf5b911eca73566698e21b) did not add enough lines to change the coverage, but with the placeholder and tests (https://github.com/NIEHS/amadeus/pull/56/commits/d4aca65e6bf787680a4b6726f6db936decf3ed95) the patch coverage increased as expected. The check passed and the gh-pages/cov_current.Rout updated to 99.07 (https://github.com/NIEHS/amadeus/blob/gh-pages/cov_current.Rout).

One issue might be related to closing pull requests. If I closed this PR, for example, the gh-pages/cov_current.Rout would remain 99.07 even without the new tests. I will add a line to save the previous coverage in the GitHub pages in case we need to abandon a PR, but even this may lead to mixups with the coverage.

mitchellmanware commented 3 months ago

Adding

      - name: Overwrite cov_current.Rout
        if: ${{ github.event_name == 'push' }}

section (fd5156b) and if statement now only overwrites the gh-pages/cov_current.Rout via push to main. Pull requests run coverage comparison without updating the file. I manually restored the cov_current.Rout file to 99.05 prior to running this newest test.