search

NIEHS / beethoven

BEETHOVEN is: Building an Extensible, rEproducible, Test-driven, Harmonized, Open-source, Versioned, ENsemble model for air quality
https://niehs.github.io/beethoven/
Other
4 stars 0 forks source link

Download and create NEI non-point source data #199

Closed dawranadeep closed 7 months ago

dawranadeep commented 8 months ago

1) Using county-wise emission data instead from NEI 2017 and 2020. 2) Download code is at https://github.com/Spatiotemporal-Exposures-and-Toxicology/NRTAPmodel/blob/download_aadt/R/download_aadt.txt

kyle-messier commented 7 months ago
mitchellmanware commented 7 months ago

@sigmafelix

Related- I have covariate calculation functions for narr and geos with tests almost complete. I will clone branch isong-calc-covars, contribute my functions and tests, and then pull request back to your branch.

Should be complete by tomorrow (1/5).

dawranadeep commented 7 months ago

1) Code at https://github.com/Spatiotemporal-Exposures-and-Toxicology/NRTAPmodel/blob/download_aadt/R/compute_NEI.R

2) Required data at /Projects/NRT-AP-Model/input/NEI

3) NEI data download code at https://github.com/Spatiotemporal-Exposures-and-Toxicology/NRTAPmodel/blob/download_aadt/R/download_aadt.txt

kyle-messier commented 7 months ago

@dawranadeep please submit a pull request to see if code updates pass tests. You can check locally first if you want.

eva0marques commented 7 months ago

@dawranadeep @sigmafelix I am renaming /Volumes/set/Projects/NRT-AP-Model/input/NEI/aadt2020/onroad123.csv as /Volumes/set/Projects/NRT-AP-Model/input/NEI/aadt2020/onroad_123.csv. It is necessary for the data path dictionary in /inst/extdata/downloaded_files_metadata.csv and I guess it is an unwanted error.

sigmafelix commented 7 months ago

@eva0marques Is the metadata csv file only for our pipeline or for general use? If the latter is the case, I suggest keeping the original file name in the zip file as the decision will affect future maintenance load to change file names accordingly (i.e., in unzipping part). As NEI/AADT data will be maintained in the separate year's directories, we will be fine to use the file names as they are.

sigmafelix commented 7 months ago

@dawranadeep NEI downloading and calculation functions were tested and integrated into the main branch. If you already put the calculated covariates into our team project directory in DDN, please close this issue.