Check all the testthat() for calc_ functions to be consistent with testdata generated by #233

NIEHS / beethoven

BEETHOVEN is: Building an Extensible, rEproducible, Test-driven, Harmonized, Open-source, Versioned, ENsemble model for air quality

https://niehs.github.io/beethoven/

Other

2 stars 0 forks source link

Check all the testthat() for calc_ functions to be consistent with testdata generated by #233 #269

Closed eva0marques closed 3 weeks ago

mitchellmanware commented 5 months ago

@eva0marques Unit and integration tests for import_geos and covar_geos are (in production) on the mm-process-functions branch. import_geos should be able to run with test GEOS-CF data, and pass cleanded data to covar_geos.

Message or comment when data is created, thanks!

eva0marques commented 5 months ago

@mitchellmanware Nice, thank you. I was thinking that for the moment I should store the testdata locally on the /ddn/gs1/group/set/Projects/NRT-AP-Model/ folder so that you can use the GEOS-CF testdata I extracted for your testing.

mitchellmanware commented 5 months ago

@eva0marques That would be perfect

eva0marques commented 5 months ago

@Spatiotemporal-Exposures-and-Toxicology I want to copy my /ddn/gs1/home/marquesel/NRTAPmodel/NRTAPmodel/testdata/raw folder in the /ddn/gs1/group/set/Projects/NRT-AP-Model/ repository but it sounds that I am not allowed to do that. Do you think you can give me the rights to do it (or do it)?

mitchellmanware commented 5 months ago

I have copied covariate data into that folder from local. Should be in bash

cp /ddn/gs1/home/marquesel/NRTAPmodel/NRTAPmodel/tests/testdata/raw /ddn/gs1/group/set/Projects/NRT-AP-Model/tests/testdata/raw

"tests/" folder is missing from your home directory if that is the exact path you used

eva0marques commented 5 months ago

I used this exact command line but I had a Permission denied error (and I do not see what you mean, I do have the tests/ folder k

eva0marques commented 5 months ago

Oh ok you're right in my previous message I forgot the tests/ folder but I didn't forget it in my command line :) Thank you for copying the data anyway!

kyle-messier commented 3 weeks ago

@eva0marques @mitchellmanware Looks like it can be closed. Re-open if needed.