NIEHS / beethoven

BEETHOVEN is: Building an Extensible, rEproducible, Test-driven, Harmonized, Open-source, Versioned, ENsemble model for air quality
https://niehs.github.io/beethoven/
Other
5 stars 0 forks source link

Refactor `init/targets/targets_download` #362

Closed kyle-messier closed 3 weeks ago

kyle-messier commented 1 month ago

Refactor 0.4.1 init/targets/targets_download

See for sketch: https://github.com/NIEHS/beethoven/issues/361#issuecomment-2383452703

mitchellmanware commented 1 month ago

@kyle-messier For the argument setup, do we want to continue using the loadargs(file_prep_calc_args, ...) method for arguments, where file_prep_calc_args is the path to the calc_spec.qs file? Or should we transition all to a targets-based approach, where all argument functions are stored as targets not file paths?

kyle-messier commented 1 month ago

I think we have one line of code in _targets.R that specifies the time range desired, then that feeds into the first target. Then initialization occurs through targets, so I guess more or less the latter.

mitchellmanware commented 1 month ago

I think we can + should set arglist_download as a target, not as a global object in the _targets.R file. Editing the common time period as a target should invalidate but maintain branches for downstream targets.