search

NIEHS / beethoven

BEETHOVEN is: Building an Extensible, rEproducible, Test-driven, Harmonized, Open-source, Versioned, ENsemble model for air quality
https://niehs.github.io/beethoven/
Other
5 stars 0 forks source link

debug in progress (20241115) #378

Closed sigmafelix closed 3 days ago

sigmafelix commented 3 days ago

Let me know if there needs updates before pulling. Thank you.

kyle-messier commented 3 days ago
  • Per amadeus update, all calc_* functions are renamed to calculate_*
  • Dropped future and future.apply functions in calculate.R
  • Debugged site calculation except for parts utilizing bulk raster files (i.e., NASA products)

Let me know if there needs updates before pulling. Thank you.

Thanks @sigmafelix. Are you working off the dev or dev-1028 branches? Those have the most recent refactoring updates. Although @mitchellmanware is working on more updates to ensure the proper branching and skipping with new data downloads.

One thought here and related to amadeus, perhaps worth an offline discussion with @mitchellmanware are the modis variables. There are a few issues open on amadeus related to modis, but they probably need clarification for you. Basically, the sparsity of time needs to be resolved more cleanly since the download expectation is by a given day.

sigmafelix commented 3 days ago

@kyle-messier This branch is based on dev. I will recheck dev-1028 and make a new PR.

sigmafelix commented 3 days ago

@kyle-messier Sure, the modis download function crawls the list of files from the remote server directories and use the file list as it is. Therefore, I think the sparsity of dates should not matter in downloading files. An error may surface if the NASA data are missing somehow during the input period. Exception handling by try or tryCatch would resolve that problem. I will look at this problem. Thank you.