Final Model Output Unit Test - Geographic - Check that coordinate names are according to a standard

NIEHS / beethoven

BEETHOVEN is: Building an Extensible, rEproducible, Test-driven, Harmonized, Open-source, Versioned, ENsemble model for air quality

https://niehs.github.io/beethoven/

Other

4 stars 0 forks source link

Final Model Output Unit Test - Geographic - Check that coordinate names are according to a standard #47

Closed kyle-messier closed 10 months ago

sigmafelix commented 10 months ago

Do we want to use longitude and latitude or X/x and Y/y? Since we have our standards for both geographic and projected coordinate reference systems, longitude and latitude would make some confusions. If single-letter column name is not preferred, we could add a prefix coord_ or coordinate_.

kyle-messier commented 10 months ago

@sigmafelix I believe @eva0marques is using lon and lat, respectively. You bring up a good point though and I can see x/y as being preferable. At the moment, I am good with whatever you and Eva decide.

sigmafelix commented 10 months ago

@Spatiotemporal-Exposures-and-Toxicology Thank you. @eva0marques, what do you think of my opinion about long/lat vs. X/Y?

sigmafelix commented 10 months ago

After the discussion with Eva, we decided on using lon and lat in stdt objects. Strict name checking is included in data conversion functions and tests. I will close the issue.