TomCarlson-NTAC commented 3 years ago

Create a structures:AdapterType for adapter types to extend, rather than including the one-off attribute appinfo:externalAdapterTypeIndicator in type definitions.

This would be consistent with the way association, augmentation, and metadata types are defined:

adapter types: Extend structures:AdapterType
association types: Extend structures:AssociationType or a derivative
augmentation types: Extend structures:AugmentationType
metadata types: Extend structures:MetadataType
object types: Extend structures:ObjectType or a derivative
adapter types: Extend structures:ObjectType and add appinfo:externalAdapterTypeIndicator="true"

Current

<xs:complexType name="GeometryType" appinfo:externalAdapterTypeIndicator="true">
  <xs:complexContent>
    <xs:extension base="structures:ObjectType">
      <xs:sequence>
        <xs:element ref="gml:AbstractGeometry" minOccurs="1" maxOccurs="1"/>
      </xs:sequence>
    </xs:extension>
  </xs:complexContent>
</xs:complexType>

Proposed

<xs:complexType name="GeometryType">
  <xs:complexContent>
    <xs:extension base="structures:AdapterType">
      <xs:sequence>
        <xs:element ref="gml:AbstractGeometry" minOccurs="1" maxOccurs="1"/>
      </xs:sequence>
    </xs:extension>
  </xs:complexContent>
</xs:complexType>

resolved Folks are fine with this.

cdmgtri commented 2 years ago

NDR adjustments:

[ ] Rule 10-8: External adapter type has indicator
[ ] Rule 10-9: Structure of external adapter type definition follows pattern
[ ] Rule 10-71: External adapter type indicator annotates complex type

cdmgtri commented 1 year ago

Migrated to niemopen/niem-naming-design-rules#4

NIEM / NIEM-NDR

Adapter types #115

resolved Folks are fine with this.