NIEM / NIEM-Releases

Repository for releases of the National Information Exchange Model
https://niem.github.io/niem-releases/
87 stars 23 forks source link

Biometrics component definition updates #228

Closed cdmgtri closed 2 years ago

cdmgtri commented 2 years ago

Update the following definitions:

  1. The documentation for DNAInstrumentProcessType in RC2

    “A data type for a description of the DNA instrument testing process used to produce a DNA profile” was from an earlier version. I am not sure how this older version of the documentation got into RC2.

    In RC1, the documentation was

    “A data type for a description of the DNA instrument testing process used to produce DNA raw data and in some cases, a DNA profile.”

    I don’t know who initially put this description in RC1, but I think it is a more accurate description than the shorter one. DNA instrument always capture and output sequence data. A DNA profile implies a set of DNA allele calls inferred from the sequence data. But there are cases where allele calls may not be made because the sequence data fails to meet the threshold requirement. In these cases, there are still raw data (sequence data) in the output even though there is no allele calls (profile). Maybe “in some cases” does not reflect the reality. Could we use “in most cases” instead? That is, use the following documentation

    “A data type for a description of the DNA instrument testing process used to produce DNA raw data and in most cases, a DNA profile.”

  2. The documentation for DNAAlleleCall1Text in RC2

    “A description of the allele call, e.g. "X" or "XY" for locus Amelogenin, or the number of repeat units for an alllele of locus CSF1PO.”

    is incorrect. Please change it back to the RC1 version

    “A description of the allele call, e.g. "X" or "Y" for an allele of locus Amelogenin, or the number of repeat units for an allele of locus CSF1PO.”

    DNAAlleleCall1Text is an allele value, not a genotype value. Note that I added a few words for Amelogenin for clarification.

  3. The documentation for DNASTRProfilePartialIndicator in RC2

    “True if one or more loci in the Kit used for the STR typing did not yield result; false otherwise. This indicator can be used to assess the quality of the STR profile.”

    was from an earlier version. Please change it back to the first part of the RC1 version

    “True if one or more loci in the Kit used for the STR typing did not yield result or yielded partial result; false otherwise. This indicator can be used to assess the quality of the STR profile.”

    A profile may have results for all loci. But the value of DNASTRProfilePartialIndicator should still be True if one or more loci has partial result due to allele dropouts. This documentation is based on a comment from the FBI CODIS.

  4. Make the documentation of DNAEncodingType consistent with the updated documentation of “DNAEncoding”. That is, use the following documentation

    “A data type for an encoding or representation of the DNA data from a person (can be a composite profile based on multiple DNA samples) or a DNA sample (can be a single-source sample or a mixture sample from a crime scene).”

cdmgtri commented 2 years ago

Updated in NIEM 5.1 RC3.