Several lines hidden when following an anchor link

NIEM / NIEM.github.io

NIEM is a community-driven, standards-based approach to exchanging information.

http://niem.github.io

26 stars 35 forks source link

Several lines hidden when following an anchor link #31

Open cdmgtri opened 6 years ago

cdmgtri commented 6 years ago

Following a link to an anchor can be confusing. The first several lines that should appear are hidden by the menu bar across the top.

Steps to recreate:

Go to http://niem.github.io/json/guidance/
Click on the link "Introduction" under the "Content" section
Expected behavior: should see section header "1. Introduction"
Actual behavior:
- Section header is hidden under the menu bar.
- First fully visible line is the first sentence from the second paragraph of that section.

cdmgtri commented 6 years ago

Local fix in the cdmgtri fork at commit eb6077ec743568294126eb789f26e2a7c131ad3f

jasonlancaster commented 6 years ago

This seems to be working on my local environment and production. Perhaps issue can be closed?

cdmgtri commented 6 years ago

I came across a bug when links have section numbers generated based off of the kramdown TOC. The section number gets split off from the section heading.

Click on any section in the JSON guidance TOC and then scroll back up for an example.

jasonlancaster commented 6 years ago

Section headers appear to be working for me (see below)... are you saying that TOC itself at the top should be an ol instead of a ul element?

cdmgtri commented 6 years ago

This is what I noticed on Chrome with headers that have automatically-generated numbers:

section-number

The page shift is occurring between the number (added with a ::before) and the header itself. Links without the numbers seem fine.

cdmgtri commented 3 years ago

Updated link demonstrating issue.