NIFTy-PPL / NIFTy

Probabilistic programming framework for signal inference algorithms that operate regardless of the underlying grids and their resolutions
https://ift.pages.mpcdf.de/nifty/index.html
GNU General Public License v3.0
17 stars 2 forks source link

Missing DOIs for references #22

Closed Abinashbunty closed 4 months ago

Abinashbunty commented 4 months ago

Hi authors. This issue is part of my ongoing review in openjournals/joss-reviews#6593

When running the checks for the references, the bot throws warnings for the following references. I have gathered the DOIs for most except some software based references. Feel free to have a look into it. πŸ˜„

Edenhofer commented 4 months ago

Many thanks for going through the trouble of finding all the DOIs! I'm currently on vacation without my laptop until the the end of next week but I'll incorporate the DOIs right afterwards.

Edenhofer commented 4 months ago

Thanks for the DOIs! I fixed most of them but left some of them as is since the DOIs are references to the arXiv paper and not the journal publication. Unfortunately, some of the ML journals/conferences don't issue DOIs and hence these publications then don't have any even if their corresponding arXiV paper has one.

Edenhofer commented 4 months ago

@Abinashbunty Are you ok with not adding DOIs to arXiv if the work is published in a journal and technically doesn't have a DOI?

Edenhofer commented 3 months ago

@Abinashbunty Are you happy with this logic of adding DOIs or do you see a better avenue here? In case of the former, could you please confirm in the NIFTy JOSS review that you are okay with it.

Abinashbunty commented 3 months ago

Hi @Edenhofer It is fine by me. πŸ‘πŸ» I know the references should be some journal at least and also verified that they are indeed published but don't have a DOI. I just wanted to make sure the bot doesn't complain.

Nevertheless, I approve. πŸ˜„

Edenhofer commented 3 months ago

Perfect! Thank you for your quick response!