Feature/unit tests - Githubissues

NIIF / simplesamlphp-module-attributescope

Filter to remove attribute values which are not properly scoped.

1 stars 4 forks source link

Feature/unit tests #1

Closed pradtke closed 8 years ago

pradtke commented 8 years ago

Add some unit tests. I plan to make some future enhancements and wanted the base functionality covered with tests. Thanks for contributing the original modules

sitya commented 8 years ago

Thanks for the PR, it is great. I may have only two minor remark:

there is a missing newline from the end of .gitignore
IMHO line 121 in tests/lib/Auth/Process/FilterAttributesTest.php could be deleted, if we do not need it

pradtke commented 8 years ago

I've made the suggested changes.

sitya commented 8 years ago

Thanks @pradtke !