search

NIIF / simplesamlphp-module-authtfaga

Two-factor authentication module for simpleSAMLphp using Google Authenticator
12 stars 10 forks source link

Incompatible with Latest stable version (1.14.0) #1

Closed m0urs closed 8 years ago

m0urs commented 8 years ago

Hi Frank,

could it be that this module is not compatibel with Latest stable version (1.14.0) of SimpleSAML? I changed two things in login.php and in general it seems to work. But the UI seems to be broken and I guess some more things are broken too. Have a look how the UI of the login page looks for me (enclosed screenshot).

Thanks, Michael

image

sitya commented 8 years ago

Hi,

could it be that this module is not compatibel with Latest stable version (1.14.0) of SimpleSAML? I changed two things in login.php and in general it seems to work. But the UI seems to be broken and I guess some more things are broken too. Have a look how the UI of the login page looks for me (enclosed screenshot).

thanks for the report. There were two incompatibile line in www/login.php, I have fixed it. Now I checked with a 1.14.0 (commit: 03c6303) simplesamlphp and it worked fine.

m0urs commented 8 years ago

Hi Frank,

thanks a lot. However it still looks a bit strange to me. Please have a look at this screenshot. This is what I get after I login with my user / password and when the Google Authenticator code should run:

[image: Inline-Bild 1]

In general I would say it works, however soemthing still is broken. Maybe something I did wrong?

Do you have any other idea?

Thanks, Michael

2016-02-23 14:00 GMT+01:00 Frank Tamás notifications@github.com:

Hi,

could it be that this module is not compatibel with Latest stable version (1.14.0) of SimpleSAML? I changed two things in login.php and in general it seems to work. But the UI seems to be broken and I guess some more things are broken too. Have a look how the UI of the login page looks for me (enclosed screenshot).

thanks for the report. There were two incompatibile line in www/login.php, I have fixed it. Now I checked with a 1.14.0 (commit: 03c6303) simplesamlphp and it worked fine.

— Reply to this email directly or view it on GitHub https://github.com/NIIF/simplesamlphp-module-authtfaga/issues/1#issuecomment-187689341 .

sitya commented 8 years ago

On 2016. febr. 23., at 14:12, Michael Urspringer notifications@github.com wrote:

thanks a lot. However it still looks a bit strange to me. Please have a look at this screenshot.

I did.

This is what I get after I login with my user / password and when the Google Authenticator code should run:

In general I would say it works, however soemthing still is broken. Maybe something I did wrong?

I think so. I did a fresh install as I wrote and it works perfectly.

m0urs commented 8 years ago

Hi Frank,

found the issue, just for your information. The PHP setting "short_open_tag" needs to be set to "On" as you are using short tags in your code ;-) By default this was set to "Off" in my PHP installation. Now the errors are gone.

short_open_tag On

Regards, Michael

2016-02-23 14:17 GMT+01:00 Frank Tamás notifications@github.com:

On 2016. febr. 23., at 14:12, Michael Urspringer < notifications@github.com> wrote:

thanks a lot. However it still looks a bit strange to me. Please have a look at this screenshot.

I did.

This is what I get after I login with my user / password and when the Google Authenticator code should run:

In general I would say it works, however soemthing still is broken. Maybe something I did wrong?

I think so. I did a fresh install as I wrote and it works perfectly.

— Reply to this email directly or view it on GitHub https://github.com/NIIF/simplesamlphp-module-authtfaga/issues/1#issuecomment-187693917 .