search

NINAnor / python-template

1 stars 0 forks source link

nina-python-init.py mentioned in .gitignore #12

Open frafra opened 1 month ago

frafra commented 1 month ago

https://github.com/NINAnor/python-template/blob/6c8cebe5d4b316c7b74c6192d5454b2de166c77c/python/.gitignore.jinja#L178

It would be better not having a line referring to such script in the resulting .gitignore file.

frafra commented 1 month ago

Here too: https://github.com/NINAnor/python-template/blob/6c8cebe5d4b316c7b74c6192d5454b2de166c77c/pyproject.toml#L10

nicokant commented 1 month ago

Disagree on the first one: when the template is generated the file is included, and the file itself setups git. To remove it from .gitignore we should never use git add . and then manually specify the files to add (but we don't know them all).

Disagree on the second one: same as #15, we should not include then and copy-paste for different templates? The root pyproject.toml requires those lines.

frafra commented 1 month ago

That file belongs to the template, not to the generated project: do we agree on that?