search

NIRALUser / GROUPS

Group wise registration for 3d-models
Apache License 2.0
0 stars 11 forks source link

Simplify RigidAlignmentModule and GroupWiseRegistrationModule #24

Closed jcfr closed 5 years ago

jcfr commented 5 years ago

When built against Slicer, the latest version of ShapePopulationViewer (SPV) is built as a loadable module.

This means that models already loaded in Slicer can easily be loaded in SPV, models can also be drag-and-dropped and loaded automatically.

This means that that the workflow in RigidAlignmentModule (or GroupWiseRegistrationModule) should be updated.

Currently the workflow is expected to be the following:

  1. Display shape in shape population viewer by starting the CLI and expect the user to select entries from the CSV dialog. See here
  2. Run rigid alignment CLI (or GROUPS CLI)
  3. Run surf remesh CLI
  4. Display shape in shape population viewer by starting the CLI and expecting the user to select entries from the CSV dialog. See here

A possible workflow could be the following:

  1. Run rigid alignment CLI (or GROUPS CLI)
  2. Run surf remesh CLI
  3. Automatically select SPV and load shapes (without creating intermediate CSV files)
bpaniagua commented 5 years ago

Thanks @jcfr

@styner @juanprietob @mmmosman88 Could you please let us know what is the behavior you wanted and why in this module so we can decide how / if needs modification before including in SALT?

Thank you! Bea

jcfr commented 5 years ago

Would also appreciate if you could review changes in https://github.com/NIRALUser/GROUPS/pull/25 and also provide test data for validating the workflow.

juanprietob commented 5 years ago

@bpaniagua The latter option is OK for me for the expected behavior @jcfr any output from SPHARM can be used here.

juanprietob commented 5 years ago

This has all been addressed.