Open allemangD opened 2 years ago
Changes have been integrated in the scikit-build project.
Worth noting that related changes have already been integrated in Slicer in these commits: https://github.com/Slicer/Slicer/pull/5817/commits
Could you confirm that the remaining tasks would be to backport the commits to the v4.11
branch ?
Additionally, local checkout of Slicier 4.11 on each factory (metroxplex
, overload
and factory-south-macos
) has been updated to include these commits.
@allemangD Let me know if anything else need to be done to address this issue.
The version of
FindVcvars.cmake
used here is a bit out-of-date and does not support any VS 2019 build.In particular, I am on VS 1929, which would be added by this PR: https://github.com/scikit-build/cmake-FindVcvars/pull/1
It would also be helpful to update
FindVcvars
in Slicer proper once the above PR is merged; both on the master and v4.11 branches.