search

NIRALUser / GROUPS

Group wise registration for 3d-models
Apache License 2.0
0 stars 11 forks source link

BUG: Fix RigidAlignmentModuleMetadata #36

Closed Connor-Bowley closed 2 years ago

Connor-Bowley commented 2 years ago

The metadata was no longer being installed to the correct path during build. I believe this was because of the relative path that moved up a directory.

Connor-Bowley commented 2 years ago

@jcfr @allemangD @bpaniagua Please review.

jcfr commented 2 years ago

Could you confirm that (1) this fixes a regression introduced by https://github.com/NIRALUser/GROUPS/commit/38274393811c0d4d3a8d0fb47b0789704fee34d7 and (2) packaging of the extension still works.

Connor-Bowley commented 2 years ago

I was able to successfully package on Linux. In the package The _RigidAlignmentModuleMetadata folder contained a correct __init__.py and was in the lib/Slicer-5.1/qt-scripted-modules/ directory, which I believe is correct.

Connor-Bowley commented 2 years ago

Regarding the regression, is being able to package, as well as having this working successful in a SlicerSALT fork enough to say the regression is no longer an issue?

jcfr commented 2 years ago

Regarding the regression, is being able to package, as well as having this working successful in a SlicerSALT fork enough to say the regression is no longer an issue?

Having it work from both the build and install trees on windows and linux would be sufficient.

I will trigger a windows build & package of the extension to confirm

jcfr commented 2 years ago

Windows

build

image

package

image

Connor-Bowley commented 2 years ago

@jcfr Can you merge? I do not have merge access to this repository.