Prevent build-system regression setting up continuous integration

jcfr commented 6 years ago

Summary

A year ago, a set of changes fixing build errors, removing the need for ITKv3 compatibility and ITKDeprecated, modernizing the build-system and streamlining the integration of niral_utitlies in project like Slicer was proposed by @jcfr and integrated by @styner. For reference, the full list of changes is reported below.

It turns out that 4a841de14d introduced a regression and inadvertently removed niral_utilitiesConfig.cmake file.

Thanks to @juanprietob and the version control history, the issue was fixed in 47d38ac497941e

Proposed solution

To avoid such issue from happening, I suggest to setup continuous integration for this project. A possible approach would be to use CircleCI to build the project, execute test and also try to configure a simple project using find_package(niral_utitlies REQUIRED)

Full list of changes

5946726 - README: Improve readbility of module listing
6e1cfd4 - README: Sort module alphabetically
635e79d - README: Fix rendering of section headers on GitHub
5505d25 - ENH: Update external project references to remove jcfr fork references
a8635a0 - ENH: Update niral_utilitiesExternalProject to support GIT_SHALLOW
00269d3 - STYLE: Improve TransformDeformationField build system
185a63a - COMP: Update IntensityRescaler do fix link error about missing vtkFiltering
f3bf6e5 - STYLE: Improve build system associated with Unsupported modules
fcb59b2 - COMP: Update PolyDataCompression to fix configuration issue
8b1b9d3 - COMP: Pass CMAKE_CXX_FLAGS for each build type only if needed
8d139ea - ENH: Add convenient function "niral_add_executable" to streamline maintenance
906538e - ENH: Update ImageNoise module to use SEMMacroBuildCLI
0bc77ed - COMP: Fix build error skipping install of external projects
de579b3 - COMP: Prevent "You are in 'detached HEAD' state." git warning.
904b1e6 - COMP: Optionally initialize CMAKE_BUILD_TYPE and propagate it only if needed
8750f91 - COMP: Ensure both regular executable and CLI executable are created in "bin"
3f1a9fe - COMP: niral_utilitiesExternalProject: Run install command in parallel if possible
441673f - COMP: Do not propagate unused variables to external projects
13e231c - COMP: niral_utilitiesExternalProject: Conditionally specify CMAKE_BUNDLE_OUTPUT_DIRECTORY
658df2e - ENH: Update "niral_utilitiesExternalProject" to display external project name
9b2b2a6 - COMP: Mark VTK and ITK as REQUIRED, fix indent and simplify niral_utilitiesExternalProject
4cbd396 - COMP: Integrate CurveCompare using niral_utilitiesExternalProject
f8b44ca - STYLE: Removed swap file inadvertently committed
4eb69c7 - COMP: Remove unused MaurerDistanceTransform/Testing directory
6c8ac1b - COMP: Fix shadow warning in ImageMath
50cae25 - COMP: Fix warnings: typedef locally defined but not used [-Wunused-local-typedefs]
6b09db4 - ENH: Remove requirement on ITK build with ITKV3_COMPATIBILITY enabled
c857b1c - ENH: Add itkDICOMSeriesFileNames files based of InsightSoftwareConsortium/ITK@d36ff8a
4a841de - COMP: Update minimum required CMake version to match Slicer requirements

juanprietob commented 6 years ago

Sounds like a plan, how do I get with circleCI?

jcfr commented 6 years ago

I suggest you follow the step outlined on this page CircleCI: Enable automated build of your GitHub project

If for some reason, you can't see your organization scroll down the page and read more details in the How to Re-enable CircleCI for a GitHub Organization ?.

jcfr commented 6 years ago

Once CircleCI is activated, we will be able to start adding a .circleci/config.yml file

NIRALUser / niral_utilities