NIRALUser / niral_utilities

NIRAL Utilities are open-source applications developped at UNC-Chapel Hill in the Neuro Image Research and Analysis Lab (NIRAL)
http://www.nitrc.org/projects/niral_utilities
Apache License 2.0
7 stars 12 forks source link

Slicer updates preparation #30

Closed hjmjohnson closed 2 years ago

hjmjohnson commented 2 years ago

These patches allow building this toolkit with C++14, VTK 9, & ITK 5.3.

Fairly simple changes were made to allow building the external packages:

 COMPILE_3D4DImageConversion      ON                                                                                                                                                                                                     
 COMPILE_CONVERTITKFORMATS        ON                                                                                                                                                                                                     
 COMPILE_CROPTOOLS                ON                                                                                                                         
 COMPILE_CombineDWIs              ON               
 COMPILE_DTITensorNormalization   ON                                                                                                                                                                                                     
 COMPILE_DWI_NIFTINRRDCONVERSIO   ON                                                                                                                                                                                                     
 COMPILE_IMAGEMATH                ON                                                                                                                                                                                                     
 COMPILE_IMAGESTAT                ON                                                                                                                                                                                                     
 COMPILE_ITKTransformTools        ON                                                                                                                                                                                                     
 COMPILE_ImageNoise               ON                                                                                                                                                                                                     
 COMPILE_MAURERDISTANCETRANSFOR   ON                                                                                                                                                                                                     
 COMPILE_MULTIATLASSEG            ON                                                                                                                                                                                                     
 COMPILE_NormalizeDWIGradientVe   ON                                                                                                                                                                                                     
 COMPILE_POLYDATAMERGE            ON                                                                                                                                                                                                     
 COMPILE_POLYDATATRANSFORM        ON                                                                                                                                                                                                     
 COMPILE_ReadImageHeader          ON   

The following packages have not yet been updated.

 COMPILE_PolyDataCompression      OFF                                                                                                                                                                                                    
 COMPILE_CURVECOMPARE             OFF                                                                                                                                                                                                  
 COMPILE_CurveCompare             OFF                                                                                                                                                                                                    
 COMPILE_Unsupported              OFF 
hjmjohnson commented 2 years ago

@jcfr I'm preparing some of the historical tools for DTI processing for the next release of Slicer.

hjmjohnson commented 2 years ago

@styner FYI: I'm preparing some of the historical tools I've used from your lab for use with the latest version of Slicer.

Are these tools still worth maintaining as a whole, or are some of the tools outdated?

FYI: I am also updated https://github.com/NIRALUser/DTIProcessToolkit/pull/50 which will depend on this set of changes.

styner commented 2 years ago

Thanks for updating these. We are indeed still using these regularly and though some are outdated and do not need to be maintained (from our end): 3D4DImageConversion, DTITensorNormalization, DWI_NIFTINRRDCONVERSION, ImageNoise, anything in Unsupported and one of the curve comparison (not sure which is right one of the 2). Thanks also for updating the dtiprocesstoolkit

hjmjohnson commented 2 years ago

@styner No problem. Great tools need a little love once in a while :). I have also updated all the other packages that this one depends upon and verified that they build. After those other packages are merged, the hashes of those packages need to be updated for this repo as well.

hjmjohnson commented 2 years ago

@styner NOTE: This PR should work for all the internally contained source code.

bpaniagua commented 2 years ago

@styner, ok to merge?

styner commented 2 years ago

Yes, ok to merge

hjmjohnson commented 2 years ago

@bpaniagua A follow-up PR will be needed once the external code repos that this depends upon are also updated.