plot button is adding traces to existing plot

NIST-ISODB / isotherm-digitizer-panel

Contribution form for NIST adsorption isotherm database implemented using pyviz panel

2 stars 3 forks source link

plot button is adding traces to existing plot #33

Closed dwsideriusNIST closed 4 years ago

dwsideriusNIST commented 4 years ago

If a user plots one isotherm, then goes back and clicks "plot data" again without reloading the panel, a new data trace is added to the plot figure. It should plot only the current isotherm.

This can be an issue because users will want to:

Fill in the form, paste in an isotherm and then generate the JSON Go back to the form, modify the necessary parts, then generate JSON for the isotherm.

Reloading the panel app will clear out a lot of data that can be re-used to save effort.

ltalirz commented 4 years ago

Agreed, this is easy to fix

dwsideriusNIST commented 4 years ago

I'm assuming that this depends on a more recent version of panel, as the plot behaves oddly on my Mac (panel is mainline from conda-forge 0.9.7). The first instance of Plot Data is fine, but the second creates an overlay of the axes (maybe the data too, but I can't see anything):

ltalirz commented 4 years ago

Thanks @dwsideriusNIST - I can reproduce this - this is a bug.